From 4cb86f4b9c2110aabae7116d3b1e8d65c30044d1 Mon Sep 17 00:00:00 2001
From: sharkdp <davidpeter@web.de>
Date: Sun, 13 Oct 2019 15:40:17 +0200
Subject: [PATCH] Do not show relative stddev for fastest entry

---
 src/hyperfine/export/markdown.rs | 16 ++++++++++------
 src/hyperfine/internal.rs        |  2 ++
 src/hyperfine/types.rs           |  4 ++--
 3 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/src/hyperfine/export/markdown.rs b/src/hyperfine/export/markdown.rs
index 1c5f78a..39ca1f8 100644
--- a/src/hyperfine/export/markdown.rs
+++ b/src/hyperfine/export/markdown.rs
@@ -53,11 +53,15 @@ fn add_table_row(dest: &mut Vec<u8>, entry: &BenchmarkResultWithRelativeSpeed, u
     let min_str = format_duration_value(result.min, Some(unit)).0;
     let max_str = format_duration_value(result.max, Some(unit)).0;
     let rel_str = format!("{:.2}", entry.relative_speed);
-    let rel_stddev_str = format!("{:.2}", entry.relative_speed_stddev);
+    let rel_stddev_str = if entry.is_fastest {
+        "".into()
+    } else {
+        format!(" ± {:.2}", entry.relative_speed_stddev)
+    };
 
     dest.extend(
         format!(
-            "| `{command}` | {mean} ± {stddev} | {min} | {max} | {rel} ± {rel_stddev} |\n",
+            "| `{command}` | {mean} ± {stddev} | {min} | {max} | {rel}{rel_stddev} |\n",
             command = result.command.replace("|", "\\|"),
             mean = mean_str,
             stddev = stddev_str,
@@ -112,7 +116,7 @@ fn test_markdown_format_ms() {
 
     let formatted_expected = format!(
         "{}\
-| `sleep 0.1` | 105.7 ± 1.6 | 102.3 | 108.0 | 1.00 ± 0.02 |
+| `sleep 0.1` | 105.7 ± 1.6 | 102.3 | 108.0 | 1.00 |
 | `sleep 2` | 2005.0 ± 2.0 | 2002.0 | 2008.0 | 18.97 ± 0.29 |
 ",
         table_header("ms".to_string())
@@ -160,7 +164,7 @@ fn test_markdown_format_s() {
     let formatted_expected = format!(
         "{}\
 | `sleep 2` | 2.005 ± 0.002 | 2.002 | 2.008 | 18.97 ± 0.29 |
-| `sleep 0.1` | 0.106 ± 0.002 | 0.102 | 0.108 | 1.00 ± 0.02 |
+| `sleep 0.1` | 0.106 ± 0.002 | 0.102 | 0.108 | 1.00 |
 ",
         table_header("s".to_string())
     );
@@ -210,7 +214,7 @@ fn test_markdown_format_time_unit_s() {
 
     let formatted_expected = format!(
         "{}\
-| `sleep 0.1` | 0.106 ± 0.002 | 0.102 | 0.108 | 1.00 ± 0.02 |
+| `sleep 0.1` | 0.106 ± 0.002 | 0.102 | 0.108 | 1.00 |
 | `sleep 2` | 2.005 ± 0.002 | 2.002 | 2.008 | 18.97 ± 0.29 |
 ",
         table_header("s".to_string())
@@ -263,7 +267,7 @@ fn test_markdown_format_time_unit_ms() {
     let formatted_expected = format!(
         "{}\
 | `sleep 2` | 2005.0 ± 2.0 | 2002.0 | 2008.0 | 18.97 ± 0.29 |
-| `sleep 0.1` | 105.7 ± 1.6 | 102.3 | 108.0 | 1.00 ± 0.02 |
+| `sleep 0.1` | 105.7 ± 1.6 | 102.3 | 108.0 | 1.00 |
 ",
         table_header("ms".to_string())
     );
diff --git a/src/hyperfine/internal.rs b/src/hyperfine/internal.rs
index 45c7138..f074a1f 100644
--- a/src/hyperfine/internal.rs
+++ b/src/hyperfine/internal.rs
@@ -50,6 +50,7 @@ pub struct BenchmarkResultWithRelativeSpeed<'a> {
     pub result: &'a BenchmarkResult,
     pub relative_speed: Scalar,
     pub relative_speed_stddev: Scalar,
+    pub is_fastest: bool,
 }
 
 fn compare_mean_time(l: &BenchmarkResult, r: &BenchmarkResult) -> Ordering {
@@ -79,6 +80,7 @@ pub fn compute_relative_speed<'a>(
                 result,
                 relative_speed: ratio,
                 relative_speed_stddev: ratio_stddev,
+                is_fastest: result == fastest,
             }
         })
         .collect()
diff --git a/src/hyperfine/types.rs b/src/hyperfine/types.rs
index 3888651..584dd36 100644
--- a/src/hyperfine/types.rs
+++ b/src/hyperfine/types.rs
@@ -11,7 +11,7 @@ pub const DEFAULT_SHELL: &str = "sh";
 #[cfg(windows)]
 pub const DEFAULT_SHELL: &str = "cmd.exe";
 
-#[derive(Debug, Clone, Serialize, Copy)]
+#[derive(Debug, Clone, Serialize, Copy, PartialEq)]
 #[serde(untagged)]
 pub enum NumericType {
     Int(i32),
@@ -181,7 +181,7 @@ impl Default for HyperfineOptions {
 }
 
 /// Set of values that will be exported.
-#[derive(Debug, Default, Clone, Serialize)]
+#[derive(Debug, Default, Clone, Serialize, PartialEq)]
 pub struct BenchmarkResult {
     /// The command that was run
     pub command: String,