Merge pull request #951 from Likio3000/codex/reject-negative-parameter-steps

Reject negative parameter steps before expanding ranges
This commit is contained in:
David Peter authored and GitHub committed 2026-10-05 11:32:10 +02:00
commit 862625fb3d
5 files changed
+54 -2

No files matched your search

+16
View File
@@ -779,6 +779,22 @@ fn performs_all_benchmarks_in_parameter_scan() {
");
}
#[test]
fn rejects_negative_parameter_steps() {
for step in ["-1", "-1.0"] {
hyperfine()
.args(["--parameter-scan", "n", "0", "1"])
.arg(format!("--parameter-step-size={step}"))
.arg("echo {n}")
.assert()
.code(1)
.stdout(predicate::str::is_empty())
.stderr(predicate::str::contains(
"Parameter step size must be positive",
));
}
}
#[test]
fn performs_reference_and_all_benchmarks_in_parameter_scan() {
let _settings = snapshot_settings().bind_to_scope();