Fix clippy warnings

This commit is contained in:
rhysd authored and David Peter committed 2021-10-17 17:03:36 +02:00
1 parent 1b7d139f21
commit f2bfedd3a6
3 files changed
+6 -4

No files matched your search

+4 -2
View File
@@ -46,14 +46,16 @@ pub struct ExportManager {
exporters: Vec<ExporterWithFilename>,
}
impl ExportManager {
impl Default for ExportManager {
/// Create a new ExportManager
pub fn new() -> ExportManager {
fn default() -> ExportManager {
ExportManager {
exporters: Vec::new(),
}
}
}
impl ExportManager {
/// Add an additional exporter to the ExportManager
pub fn add_exporter(&mut self, export_type: ExportType, filename: &str) -> Result<()> {
let _ = File::create(filename)?;
+1 -1
View File
@@ -249,7 +249,7 @@ fn build_hyperfine_options<'a>(
/// Build the ExportManager that will export the results specified
/// in the given ArgMatches
fn build_export_manager(matches: &ArgMatches<'_>) -> io::Result<ExportManager> {
let mut export_manager = ExportManager::new();
let mut export_manager = ExportManager::default();
{
let mut add_exporter = |flag, exporttype| -> io::Result<()> {
if let Some(filename) = matches.value_of(flag) {
+1 -1
View File
@@ -37,7 +37,7 @@ impl fmt::Display for Shell {
impl Shell {
/// Parse given string as shell command line
pub fn parse<'a>(s: &str) -> Result<Self, OptionsError<'a>> {
let v = shell_words::split(s.as_ref()).map_err(OptionsError::ShellParseError)?;
let v = shell_words::split(s).map_err(OptionsError::ShellParseError)?;
if v.is_empty() || v[0].is_empty() {
return Err(OptionsError::EmptyShell);
}